D18836: Make the button tooltips on the "Configure Virtual Desktops" page translatable

aacid added subscribers: mart, aacid.
aacid added a comment.


  There are three KDeclarative with their three KLocalizedContexts being created when "executing" this QML file.
  
  Only one of them has a call to setDomainTranslation, the other two are "outside" main.qml so don't get that call, that's fine.
  
  I think the problem lies in kirigami's DelegateRecycler that is using the wrong context and thus the wrong translation domain for those i18nc calls.
  
  In fact commenting out these lines
  
    if (QQmlEngine *eng = qmlEngine(this)) {
        //share context object in order to never lose track of global i18n()
        ctx->setContextObject(eng->rootContext()->contextObject());
    }
  
  fixes the problem, which makes sense because it stops using the global i18n and uses the "correct" i18n. the question is what bug was those lines supposed to fix.
  
  @mart any idea?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18836

To: yurchor, #kwin, #localization, davidedmundson
Cc: aacid, mart, victorr, davidedmundson, ngraham, broulik, pino, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol