D18818: virtualkeyboard: resize the focused window to make room for the keyboard

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  There are some open questions still:
  
  - How to deal with desktop containments in a sensible way. With this patch applets and the launcher are moved above the virtual keyboard, which is already a great improvement. But we might want to deal with them in a more nicer way.
  - Doe we want to expose the virtual keyboard position information somehow to the clients? The old text-input v2 protocol provided this information. We might want to let clients opt-in to not being size-changed, but placing the keyboard into their window instead at some proposed coordinates. I could imagine this could be nice on larger screens with multiple windows open. But this would need a text-input v4 protocol version or a separate protocol.
  - Talking about multiple windows open: currently only the input focus window is moved. What's with other windows? I might be interested in them as well on a large screen while typing into the focused window.
  
  But anyway from the demo I saw this patch makes the virtual keyboard way more usable.  So let's merge it and think about the open questions in the future again.

INLINE COMMENTS

> virtualkeyboard.h:30
> +
> +#include <KWayland/Server/surface_interface.h>
> +

Necessary?

REPOSITORY
  R108 KWin

BRANCH
  mart/resizeforkeyboard

REVISION DETAIL
  https://phabricator.kde.org/D18818

To: mart, #plasma, #kwin, bshah, graesslin, romangg
Cc: nicolasfella, mart, kwin, davidedmundson, graesslin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol