D18818: virtualkeyboard: resize the focused window to make room for the keyboard

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I'm not sure whether it's a good idea to resize windows for virtual keyboard. This can easily result in a feedback loop - the window resizes, the element with focus loses focus, keyboard closes, window resizes, element gets focus again and so on.
  
  I would prefer if we could just move the window away. This could be done just by the compositor.
  
  I'm setting to requires revision as I think from KWin point of view it's wrong to track the geometry for restore in VirtualKeyboard. For everything else the AbstractClient tracks it itself. E.g. there is a restoredGeometry for maximize and for fullscreen. I think the same should be done for virtual keyboard. This also ensures that the system is properly able to track state. The code now is dangerous. If the window is in maximized state, it will lose that state on resize and then the restore geometry gets broken.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18818

To: mart, #plasma, #kwin, bshah, graesslin, romangg
Cc: nicolasfella, mart, kwin, davidedmundson, graesslin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol