D18795: Kill KillWindow
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added a comment. In D18795#409226 <https://phabricator.kde.org/D18795#409226>, @graesslin wrote: > Workspace just does too much - it's a god object. Agreed. > Given that I'm not totally thrilled of moving more code into it which was nicely separated in a dedicated class. To be honest, so am I, but I also think that having a dedicated class for a single method is wrong, there is no cohesion. The right way would be to go with an utility function. > To me the better question would be whether we could move the remaining bits which were kept in workspace into the KillWindow class. E.g. remove the slot in Workspace and direct all usages into KillWindow. Yeah, I was also thinking about that. I came to conclusion that moving KillWindow::start to Workspace::slotKillWindow would be more simpler, though I won't insist on that and I'm okay to abandon this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D18795 To: zzag, #kwin Cc: graesslin, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart