D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule

vpilo added a comment.


  In D18458#409694 <https://phabricator.kde.org/D18458#409694>, @victorr wrote:
  
  > If you apply this patch, the translation works.F6606436: kwin-locale.patch <https://phabricator.kde.org/F6606436>
  >
  > F6606546: kwindecoration_works.jpeg <https://phabricator.kde.org/F6606546>
  
  
  Thank you! I'll commit it today. I don't think it needs a review, does it @ngraham / @davidedmundson  ?
  
  In D18458#409470 <https://phabricator.kde.org/D18458#409470>, @ngraham wrote:
  
  > So what do we do? Right now it's a pretty significant regression to not show GHNS-downloaded decorations. We still have a lot of time before Plasma 5.16 ships, but we should really fix it before them. @leinir is our GHNS/store.kde.org expert here; maybe we need a meeting-of-the-minds on this?
  
  
  the new GNS implementation is confusing. I thought I followed the apis, and in my tests it was working. But I now built kwin in a neon-developer VM, and I get issues..
  
  It looks like the installation directory is somehow wrong: on install I now get "Wrong number of installation directories given". The next time I reopen systemsettings, none of the downloaded themes are marked as installed anymore. I'll make some more tests and submit another review.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, #kwin, davidedmundson
Cc: victorr, leinir, zzag, GB_2, ngraham, broulik, kwin, jraleigh, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart