D18935: [kcmkwin/kwindecoration] Fix Get Hot New Stuff

vpilo marked an inline comment as done.
vpilo added a comment.


  In D18935#410286 <https://phabricator.kde.org/D18935#410286>, @ngraham wrote:
  
  > Lovely, works for me FWIW.
  
  
  Perfect.
  
  > Now we need a delete button on the delegates like all the other ones have, so you don't back to to back into the GHNS to remove a theme.
  
  Something for another review :) I was also thinking about doing that.

INLINE COMMENTS

> cfeck wrote in window-decorations.knsrc:65
> Since KWin itself only supports Aurorae, you don't need to add others. Third-party engines are supposed to ship their own .knsrc file, see e.g. https://cgit.kde.org/smaragd.git/tree/src/smaragd.knsrc
> 
> KWins decoration UI works fine with multiple files (at least it did; hopefully the rewrite didn't break it :)

Excellent. The new KCM UI should be making the same plugin search as before. I'll try Smaragd to test.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18935

To: vpilo, leinir, graesslin, #kwin
Cc: ngraham, cfeck, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart