D19034: [effects/backgroundcontrast] Reset vbo

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  The streaming buffer is shared so we have to reset it before rendering
  something. Otherwise, it's basically undefined behavior.
  
  For example, if the streaming buffer had been used for rendering a
  geometry with some color, then the Background Contrast effect may crash
  in GLVertexBuffer::bindArrays, it all depends on whether there is any
  bounded GLShader. To fix that, the buffer has to be reset.
  
  BUG: 356141

REPOSITORY
  R108 KWin

BRANCH
  reset-vbo

REVISION DETAIL
  https://phabricator.kde.org/D19034

AFFECTED FILES
  effects/backgroundcontrast/contrast.cpp

To: zzag, #kwin
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.