D18569: Split out a dedicated InternalClient class

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

INLINE COMMENTS

> graesslin wrote in shell_client.cpp:1303
> Yes and no. Currently this is broken. We have lots of bug reports about geometry being wrong for osd. This is in fact the main motivation for this change and the work on getting the QPA Wayland free.
> 
> I consider that this won't work after the change, but it won't be broken more than currently and will allow to fixup properly afterwards.

Agreed, there are definitely some problems with OSDs, but I personally would prefer to keep things as they are. This change is about splitting internal entities in KWin, so users shouldn't see any difference before and after.

REPOSITORY
  R108 KWin

BRANCH
  internal-client

REVISION DETAIL
  https://phabricator.kde.org/D18569

To: graesslin, #kwin, zzag
Cc: davidedmundson, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart