D16710: [wayland] Fix window sizing when restoring a window that was initially fullscreen

davidedmundson added inline comments.

INLINE COMMENTS

> shell_client_test.cpp:568
> +    QVERIFY(configureRequestedSpy.wait());
> +    QCOMPARE(configureRequestedSpy.count(), 4);
> +    QCOMPARE(configureRequestedSpy.last().first().toSize(), QSize(0, 0));

why should it be 4?

> shell_client_test.cpp:580
> +    QVERIFY(!c->isFullScreen());
> +    QCOMPARE(c->geometry(), QRect(QPoint(0, 0), QSize(100, 50)));
> +}

I don't see why the top left should always be 0,0.

That's writing tests for what the current code happens to do, not testing for what things should be doing. Arguably the window could be placed according to the placement algorithm.

Lets just check the size.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16710

To: dos, #kwin, davidedmundson
Cc: graesslin, davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart