D18705: [kcmkwin] Don't discard unsaved changes when reloading effects model

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> effectmodel.cpp:474
>  
>      m_effectsChanged = m_effectsList;
>      endResetModel();

I think there's a problem here.

Previously:
m_effectsList is the current state that we think kwin has
m_effectsChanged is what the user has set

we're now losing what we think kwin has

In ::syncEffectsToKWin  (line 484 here)
we compare the .effectsStatus of both

If a user makes a change, and then we call reload, and then the user saves:

m_effectsList[0]->effectStatus is the user set value
m_effectsList[0]->changed is true

so we'll write out the correct value in the config file all successfully

but  m_effectsList.at(it).effectStatus == m_effectsChanged.at(it).effectStatus    so we won't notify kwin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18705

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart