D19199: [platforms/fbdev] Port to AbstractOutput

davidedmundson added a comment.


  +1 to the concept
  
  On the subject of porting, don't forget about D18465 <https://phabricator.kde.org/D18465> please

INLINE COMMENTS

> fb_backend.cpp:199
> +{
> +    return m_outputs[0]->pixelSize();
> +}

Best to guard this being called before init() or if init fails.

> fb_backend.h:43
> +    }
> +    void setPixelSize(QSize set) {
> +        m_pixelSize = set;

const &

> scene_qpainter_fb_backend.cpp:87
> +
> +    Compositor::self()->aboutToSwapBuffers();
> +    m_needsFullRepaint = false;

I would move this after the

if (!Logind)

just so that we always get matching about toSwap  bufferSwapComplete pairs

> scene_qpainter_fb_backend.cpp:97
> +
> +    Compositor::self()->bufferSwapComplete();
>  }

Why are these compositor lines needed now and not before?
Same for the tracking m_needsFullRepaint?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19199

To: romangg, #kwin
Cc: davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart