D18465: [platforms/wayland] Multi output support
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added inline comments.
INLINE COMMENTS
> egl_wayland_backend.cpp:284
> {
> - m_wayland->surface()->setupFrameCallback();
> + for (auto &s: m_outputs) {
> + makeContextCurrent(s);
`*` instead of `&`.
> davidedmundson wrote in egl_wayland_backend.cpp:311
> qAsConst
>
> (in both places)
The vector elements are pointers. qAsConst does not have any advantage in this case. But I forgot the asterisk on the auto keyword. Maybe that's why you thought there should be qAsConst?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D18465
To: romangg, #kwin
Cc: davidedmundson, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart