D19199: [platforms/fbdev] Port to AbstractOutput
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg marked 2 inline comments as done. romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in fb_backend.cpp:199 > Best to guard this being called before init() or if init fails. I don't think it's necessary because the platform init should always be called before and if init fails, we're screwed anyways. But let's be sure and guard it. > davidedmundson wrote in scene_qpainter_fb_backend.cpp:97 > Why are these compositor lines needed now and not before? > Same for the tracking m_needsFullRepaint? Good question. Without full repaints, there are artifacts. I assume the difference is in the SceneQPainter to find for that. The `m_needsFullRepaint` variable I copied from some other QPainter backend code. Same for the calls to aboutToSwapBuffers and bufferSwapComplete. But these seem to be unnecessary, so I'll remove them here. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D19199 To: romangg, #kwin Cc: davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart