D19232: [wayland] Keep application startup flow inside main_wayland

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In a recent patch the newly added xwayland class ended up being
  responsible for continuing the startup, calling back into the main app
  to spawn the workspace.
  
  It moves the flow of startup about so it's not very readable or 
  following class structure.
  
  This patch moves the code back into main_wayland and removes the
  duplication between xwayland and non-xwayland modes.
  
  There was also a misnaming of methods.
  
  Previously:
  continueStartupWithScreens was called after platform screens are created
  continueStartupWithScene was called after the scene was created
  continueStartupWithXwayland was called before xwayland is created
  
  This was confusing, so the names have been shuffled around to follow a
  consistent pattern of what has been done so far.

TEST PLAN
  Started kwin_wayland in normal and xwayland mode
  Ran unit tests (though some failed due to a local unrelated and as yet unindentified bug)

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19232

AFFECTED FILES
  autotests/integration/kwin_wayland_test.cpp
  autotests/integration/kwin_wayland_test.h
  main_wayland.cpp
  main_wayland.h
  xwl/xwayland.cpp
  xwl/xwayland.h

To: davidedmundson, #kwin
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart