D19331: [wayland] Squash reconfigure methods
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. davidedmundson requested review of this revision. REVISION SUMMARY We can handle the case of a null size inside ShellClient::requestGeometry and that makes that method more robust. With that we don't need to handle separate code paths in the handler of RequestGeometryBlocker. It's not an exact identical code path, but everything still works out. If the geometry is unchanged, we'll save the positionAfterResize but when we apply it doSetGeometry will no-op. There's also an assumption that toggling maximised will always send a valid size, but that's true for the current state. TEST PLAN Ran unit tests REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D19331 AFFECTED FILES shell_client.cpp shell_client.h To: davidedmundson, #kwin Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart