D18583: Init ShellClient only when commited to the buffer

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  Looks good to me, though I'd prefer to have blockRequestGeometry method, which would be called by RequestGeoemtryBlocker and initialization routines. :-)

INLINE COMMENTS

> shell_client.h:198-200
> +    /*
> +     *  Called when the shell is created.
> +     */

I'm not sure whether `/* */` is the right choice here. Maybe use single line comments or stick with `/** **/`?

> shell_client.h:269
>  
> -    class RequestGeometryBlocker {
> +    class RequestGeometryBlocker { //TODO rename ConfigureBlocker
>      public:

Also it would be great to tell "future folks" when they could rename it to ConfigureBlocker. :-)

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18583

To: davidedmundson, #kwin, zzag
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart