D18583: Init ShellClient only when commited to the buffer

davidedmundson added a comment.


  > Looks good to me, though I'd prefer to have blockRequestGeometry method
  
  I don't think it adds a lot unless it's as a matching block/unblock pair of methods, and I deliberately refactored requestGeometry for the sole reason of having it easily re-usable for finishInit and the Blocker destructor.
  
  I've made the other two changes. Lets revisit this one when we do that rename.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18583

To: davidedmundson, #kwin, zzag
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart