D19411: [wayland] Apply window rules only to xdg-shell clients
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY There are rules that have to be applied only once, e.g. every Remember and Apply Initially rule, as well any rule that involves configuring the client. In the best scenario the compositor would evaluate such rules when the client is about to be mapped. This change limits window rules only to xdg-shell clients because right now only this protocol lets compositors intervene in the client initialization process. Also, it makes things a bit easier for us on the compositor side. Though not all issues are addressed with xdg-shell protocol. There is no way for a client to express its intent to be mapped. Thus if a client is mapped more than once, then the compositor won't be able to re-evaluate remember rules for example. In order to make this work we need changes in the protocol. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D19411 AFFECTED FILES abstract_client.cpp abstract_client.h internal_client.cpp internal_client.h shell_client.cpp shell_client.h useractions.cpp To: zzag, #kwin Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart