D19540: Verify that there is no scene windows when Scene is about to be destroyed
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY When ~Scene is called, it's not guaranteed that backend is still valid or that there is current opengl context. So, generally speaking, deleting scene windows in ~Scene is a bad idea. It's safe not to delete scene windows in ~Scene because current implementation of Compositor::finish ensures that they don't last longer than the scene. REPOSITORY R108 KWin BRANCH assert-empty-windows REVISION DETAIL https://phabricator.kde.org/D19540 AFFECTED FILES scene.cpp To: zzag, #kwin Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart