D19411: [wayland] Apply window rules only to xdg-shell clients

davidedmundson added a comment.


  > Currently, xdg-shell protocol doesn't have any mechanism that a client could use to notify the compositor about its intent to map.
  
  Yeah, it's messy. No toolkit actually does it.
  
  For popups it is forbidden.
  
  For toplevels I believe the design is as follows:
  
  - first committed  empty buffer we unmap and do nothing
  - next committed empty buffer we send a configure event  (as there's a rule you have to resend xdg shell state)
  - next committed surface has a buffer \o/
  
  Which works in theory,  but relies on extremely well behaving clients (unlike plasma-integration which injects random surface commit events)

INLINE COMMENTS

> shell_client.cpp:1880
> +{
> +    return m_xdgShellSurface;
> +}

Maybe we want to exclude anything with m_plasmaShellSurface.

Even if it works well in kwin it has potential to allow us to mess up plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19411

To: zzag, #kwin
Cc: davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart