D19052: Fix captions with non-BMP characters

Vlad Zagorodniy <[email protected]> Fri, 8 Mar 2019 08:12:59 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added inline comments.

INLINE COMMENTS

> x11_client_test.cpp:154-155
> +    // BUG: 376813
> +    QSignalSpy windowAddedSpy(effects, &EffectsHandler::windowAdded);
> +    QVERIFY(windowAddedSpy.isValid());
> +

Do we need these?

> x11_client_test.cpp:197-198
> +    QVERIFY(windowClosedSpy.wait());
> +    xcb_destroy_window(c.data(), w);
> +    c.reset();
> +}

Can it be moved up?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19052

To: cfeck, #kwin
Cc: zzag, graesslin, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart