D18818: virtualkeyboard: resize the focused window to make room for the keyboard

Marco Martin <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shell_client.cpp:904
> why this?

this is the maximized area got at line 828, which may have been adjusted to consider the keyboard space, otherwise we always get the full maximized area

> davidedmundson wrote in virtualkeyboard.cpp:156
> m_trackedClient = t;

t is not an abstractclient but a surface?

> davidedmundson wrote in virtualkeyboard.cpp:191
> If this changes whilst our text input has focus, we'll cache the wrong m_trackedClientOriginalMaxState

hmm, that should happen only when inputPanelHasBeenOpened?
(that means, the keyboard has been set yo visible only on this updateinputpanelstate has been called)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18818

To: mart, #plasma, #kwin, bshah, graesslin, romangg
Cc: nicolasfella, mart, kwin, davidedmundson, graesslin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.