D19604: RFC: Make it possible to autodetect the tablet mode

davidedmundson added a comment.


  Concept seems sensible.

INLINE COMMENTS

> tabletmodemanager.cpp:99
> +    } else {
> +        auto config = KSharedConfig::openConfig("kwinrc");
> +        KConfigGroup group(config, "TabletMode");

I'd prefer using kwin.kcfg

> tabletmodemanager.cpp:103
> +        // to enable: kwriteconfig5 --file kwinrc --group TabletMode --key DetectTabletMode true
> +        if (group.readEntry<bool>("DetectTabletMode", false)) {
> +            new TabletModeTouchpadRemovedSpy(this);

If you do have tabletModeSwitch we're still detecting a tablet mode regardless of this setting.
We need something a bit more explicit.

"SetTabletModeOnTouchPadRemoval" ?

> tabletmodemanager.cpp:120
>  {
> -    return input()->hasTabletModeSwitch();
> +    return input()->hasTabletModeSwitch() || m_detecting;
>  }

I don't really how this is meant to be used but should this be only true when there's a touch screen?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19604

To: apol, #kwin, #plasma
Cc: davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart