D19705: Force server-side decoration if no borders are forced by user

zzag added a comment.


  Code-wise this change looks okay to me, though after thinking for a bit I'm not sure whether this change makes sense logically. Maybe David could weigh in (we have plenty time before 5.15.4 is released).

INLINE COMMENTS

> maximize_test.cpp:267
> +    QVERIFY(sizeChangeRequestedSpy.wait());
> +    QCOMPARE(sizeChangeRequestedSpy.count(), 1);
> +

maybe you could check decorationConfiguredSpy.count() here as well. though in general it's a bit messy because kwin sends several configure events in this case.....

> maximize_test.cpp:269-271
> +    for (const auto &it: configureRequestedSpy) {
> +        xdgShellSurface->ackConfigure(it[2].toInt());
> +    }

just ack the last one

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19705

To: broulik, #kwin
Cc: davidedmundson, ngraham, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart