D18376: Fix software cursors with drm backend
Erik Kurzinger <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
ekurzinger added a comment. In D18376#407857 <https://phabricator.kde.org/D18376#407857>, @davidedmundson wrote: > > Instead of emitting cursorChanged from DrmBackend, modify SceneOpenGL to connect Platform::cursorChanged as opposed to Cursor::cursorChanged to the cursor texture update function. > > Where does the platform emit cursorChanged? > On wayland the only place I can see that emits Platform::cursorChanged is connected to CursorImage::changed Yes, the signal gets emitted by CursorImage::changed(), which itself is triggered by PointerInterface::cursorChanged() from KWayland. It looks like Cursor::cursorChanged() is basically just a wrapper around Platform::cursorChanged() that can be enabled with Cursor::startCursorTracking() which appears to only be used by the zoom effect at the moment. I thought that since the rest of this function interfaces with the software cursor directly through Platform's methods, connecting to Platform::cursorChanged() directly made the most sense. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D18376 To: ekurzinger, #kwin Cc: davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart