D19604: Make it possible to autodetect the tablet mode
Marco Martin <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
mart added a comment.
lgtm, maybe add a check more
INLINE COMMENTS
> tabletmodemanager.cpp:114
> + Settings settings(kwinApp()->config());
> + if (settings.tabletModeOnTouchPadRemoval()) {
> + m_detecting = true;
maybe checking touchpad and mouse? ie maybe i detached the keyboard from my transformable laptop but iattached usb mouse and keyboard, i would expect in this case to go in desktop mode
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19604
To: apol, #kwin, #plasma, davidedmundson
Cc: mart, davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol