D19690: Improve SNI text

ngraham added inline comments.

INLINE COMMENTS

> orientation_sensor.cpp:72
>              if (m_sensor->isActive()) {
> +                m_sni->setTitle(i18n("Rotate Automatically"));
>                  m_sni->setToolTipTitle(i18n("Automatic screen rotation is enabled"));

"Allow Automatic Rotation" ?

> orientation_sensor.cpp:80
> +                    case Undefined:
> +                        text = i18n("Undefined");
> +                        break;

Can we just not show any text in this state? "Undefined" is not really a useful user-facing string.

> orientation_sensor.cpp:84
> +                    case TopDown:
> +                        text = i18n("Locked Vertical");
> +                        break;

How about: "Locked: Portrait View", and the other is "Locked: Landscape View"

?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19690

To: apol, #plasma, #kwin
Cc: ngraham, arvidhansson, bruns, niccolove, ndavis, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart