D19690: Improve SNI text

Aleix Pol Gonzalez <[email protected]> Tue, 19 Mar 2019 16:21:01 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

apol added inline comments.

INLINE COMMENTS

> ngraham wrote in orientation_sensor.cpp:72
> "Allow Automatic Rotation" ?

Rotating automatically?
On Android it says "Auto-rotate".

> ngraham wrote in orientation_sensor.cpp:80
> Can we just not show any text in this state? "Undefined" is not really a useful user-facing string.

I wouldn't worry too much, this should never appear.

> ngraham wrote in orientation_sensor.cpp:84
> How about: "Locked: Portrait View", and the other is "Locked: Landscape View"
> 
> ?

I'm not convinced about the "View" bit, maybe Display would be a bit better?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19690

To: apol, #plasma, #kwin
Cc: ngraham, arvidhansson, bruns, niccolove, ndavis, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart