Re: Keystates, implementing a full Plasma on Wayland
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
Am 2019-04-03 04:45, schrieb Aleix Pol: > On Tue, Apr 2, 2019 at 1:59 PM Martin Flöser <[email protected]> > wrote: >> >> Hi Aleix, >> >> I would have approached the problem differently. First of all I don't >> think we need any new protocol for transmitting key state. That's >> already built into the wl_keyboard protocol. The "problem" with this >> protocol is that it only sends events to the focused application, >> which >> makes it not a direct solution for applications like Plasma which need >> to show the state all the time. For all other applications it would be >> fine. Firefox doesn't need to know the state if it's not focused. > > It would still be a problem if it gets out of sync, wouldn't it? (i.e. > if the state changes while out of focus) There's nothing which can go out of sync. The wl_keyboard protocol is quite neatly designed. > > I'm not sure why exporting all the data to the process (plasmashell, > screenlocker, keyboard kcm thingie) is better than having a simple > specific protocol. I'm not suggesting to send all data to the process, just the modifier event of wl_keyboard, which is exactly the same thing you need in the protocol you added. And instead of re-inventing the wheel, we use what already exists. Cheers Martin