D19708: [wayland] Finish active move-resize op when client is destroyed or unmapped
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> I'm still not quite sure what exactly we have to do when a client is unmapped. Should we send a configure event?
No-one actually unmaps and remaps the same shellclient IRL, so it's kinda moot.
In theory we shouldn't send anything till we get the next commit event on the wl_surface.
So arguably we should do something like
ShellClient::unmap() {
if (xdg) {
m_requestGeometryBlockCounter++;
connect(s, &SurfaceInterface::committed, this, &ShellClient::finishInit);
}
//existing code
}
but that's true before this patch
REPOSITORY
R108 KWin
BRANCH
shell-client-leave-move-resize
REVISION DETAIL
https://phabricator.kde.org/D19708
To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart