D20455: [qpa] Don't specify EGL_SURFACE_TYPE when choosing EGLConfig
Erik Kurzinger <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
ekurzinger created this revision. ekurzinger added a reviewer: KWin. ekurzinger added a project: KWin. Herald added a subscriber: kwin. ekurzinger requested review of this revision. REVISION SUMMARY Since QPA only performs off-screen rendering, it does not require an EGLConfig that supports any particular surface type. Currently it requests a config supporting window surfaces, however the EGLDeviceEXT platform, which is the basis of the EGLStream back-end used with the proprietary NVIDIA driver, does not support such surfaces resulting in eglChooseConfig not returning any valid configs when that back-end is in use. Since QPA doesn't actually create any window surfaces, it should be fine to remove this restriction to allow it to initialize properly with the EGLStream back-end. TEST PLAN Start a Wayland Plasma session on NVIDIA hardware with the proprietary driver (see https://phabricator.kde.org/D18570) Configure the window switcher to use the breeze theme and trigger it (with alt + tab by default) KWin should not crash and the window switcher dialogue should be displayed correctly. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D20455 AFFECTED FILES plugins/qpa/abstractplatformcontext.cpp To: ekurzinger, #kwin Cc: kwin, #kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart