D20588: Refactor getters in OutputScreens

apol added inline comments.

INLINE COMMENTS

> outputscreens.cpp:44
>  {
> -    const auto enOuts = m_platform->enabledOutputs();
> -    if (screen >= enOuts.size()) {
> -        return Screens::name(screen);
> +    if (AbstractOutput *output = findOutput(screen)) {
> +        return output->name();

You don't need to create a new function, you can use QVector::value right here. There's little point in creating a function that just creates a function.

> outputscreens.cpp:116
> +    const auto outputs = m_platform->enabledOutputs();
> +    for (int i = 0; i < outputs.size(); ++i) {
> +        const QRect &geo = outputs[i]->geometry();

I'd suggest using iterators here.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D20588

To: zzag, #kwin
Cc: apol, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart