D20621: [effects/screenedge] Support "hint-stretch-borders"

kossebau added a comment.


  @zzag Thanks for review.

INLINE COMMENTS

> zzag wrote in screenedgeeffect.cpp:347
> Could you please rename this variable? Maybe `target`? Not a serious issue but would be nice to have a bit descriptive variable names. :)

I tried to follow the name pattern of `pixmapPosition`, so thought it was descriptive, being the "rect" for the very "c" :)
`target` I would find less descriptive, being so generic, even given the context.
We see that naming is the most hard problem of software development :)
Will think about how to name before I land tomorrow, other name suggestions welcome.

REPOSITORY
  R108 KWin

BRANCH
  gloweffectsupportstretchborderhint

REVISION DETAIL
  https://phabricator.kde.org/D20621

To: kossebau, #kwin, zzag
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart