D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer

zzag added a comment.


  In general, the new window type is reasonable, though I'd prefer solution where KWin doesn't have to worry about notification urgency levels. plasmashell has already enough information about full screen clients (both on Wayland and X11), so depending on user preferences it could avoid showing notifications when required.

INLINE COMMENTS

> kwineffects.h:1887
> +     * using the non-standard _KDE_NET_WM_WINDOW_TYPE_CRITICAL_NOTIFICATION
> +     */
> +    Q_PROPERTY(bool criticalNotification READ isCriticalNotification)

In KWin we do

  /**
   *
   **/

> kwineffects.h:2269
> +     * using the non-standard _KDE_NET_WM_WINDOW_TYPE_CRITICAL_NOTIFICATION
> +     */
> +    virtual bool isCriticalNotification() const = 0;

In KWin we do

  /**
   *
   **/

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D20629

To: broulik, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart