D20937: Handle XdgShell window geometry in configure request sizes

zzag added inline comments.

INLINE COMMENTS

> shell_client_test.cpp:1484
> +    c->setGeometry(QRect(100, 100, 300, 200));
> +    configureRequestedSpy.wait();
> +    // requested geometry should not include the margins we had above

Please wrap in QVERIFY.

Also, would it be a good idea to have an explicit configureRequestedSpy.wait() right after renderAndWaitFotShown?

> shell_client_test.cpp:1489
> +    shellSurface->ackConfigure(configureRequestedSpy.last()[2].toUInt());
> +    Test::render(surface.data(), requestedSize + QSize(10 + 30, 20 + 40) , Qt::blue);
> +    geometryChangedSpy.wait();

No whitespace before comma.

> shell_client_test.cpp:1492-1493
> +
> +    // kwin's concept of geometry should remain the same
> +    QCOMPARE(c->geometry(), QRect(100, 100, 300, 200));
> +

If we add support for window rules, would geometry rules work well with GTK+ clients?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D20937

To: davidedmundson, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart