D21083: [effects/presentwindows] Allow closing windows on middle-click

ngraham created this revision.
ngraham added reviewers: KWin, davidedmundson, broulik.
Herald added a project: KWin.
Herald added a subscriber: kwin.
ngraham requested review of this revision.

REVISION SUMMARY
  The presence of a close button you can left-click does not replace the desirable
  feature to be able to middle-click on a window to close it. With this, the whole
  window is a click target, so it can be much much faster than having to aim for the
  little close button. Also it's off by default, so a user who goes out of their way
  to turn it on is signaling that they want to accept the risk of accidentally closing
  a window by accident.
  
  Finally, the feature is only enabled for middle-click, so people can never accidentally
  wreck Present Windows for themselves by assigning it to left-click by accident.
  
  This reverts commit 55585514f926d1251148e876bfe9ce3504432997 <https://phabricator.kde.org/R108:55585514f926d1251148e876bfe9ce3504432997>.

TEST PLAN
  Set "Close window" in the Present windows effect, trigger effect, and middle-click on window

REPOSITORY
  R108 KWin

BRANCH
  allow-closing-with-mouse-actions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21083

AFFECTED FILES
  effects/presentwindows/presentwindows.cpp
  effects/presentwindows/presentwindows.h
  effects/presentwindows/presentwindows_config.ui

To: ngraham, #kwin, davidedmundson, broulik
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart