D21083: [effects/presentwindows] Allow closing windows on middle-click

ngraham added a comment.


  Thanks for joining the conversation, @graesslin.
  
  I disagree with all of your arguments, and I believe the text I wrote in the Description section pre-refuted them except for two: the assertions of complex UI and code fragility.
  
  - On the subject the UI, this patch adds one entry to one combobox that already exists. It adds no new complexity to the vast majority of people who never click on the combobox. Your complaint about the general complexity of the UI is unrelated to this patch and this patch does not make the existing UI any more complex than it already is, so that cannot be a valid reason to reject it.
  
  - On the subject of code fragility, if you look at the source changes, only a very very small number of lines of code are being added, and there is no complex logic at all. In fact the feature itself is already implemented; this patch only exposes it in the user interface. I don't believe it is possible that landing this patch would make the codebase more fragile. If your fear is really that //any// changes at all would introduce risk, that would be an argument for never changing anything ever again that is incompatible with the nature of open-source software that is developed publicly and cannot possibly be correct.
  
  It is also not fair, nice, or feasible to freeze or remove features from a piece of code that is in production and relied upon by users just because you consider it unmaintainable and want to replace it. Once an adequate replacement is released, sure, //then// you freeze and deprecate the old thing. Doing that before the replacement is finished, or indeed before it's even been started (as in the case of the proposed rewritten effect), only has the effect of damaging the user experience and generating user anger towards you. If you want to rewrite this effect, then do it, but please don't throw cold water on people trying to improve the existing one.
  
  Good luck with the baby!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D21083

To: ngraham, #kwin, davidedmundson, broulik
Cc: graesslin, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart