D21083: [effects/presentwindows] Allow closing windows on middle-click

ngraham added a comment.


  Having worked on the code myself, I agree that it needs a rewrite. So let's rewrite it. But until that effort has been completed, it is not kind or fair to KWin's users or contributors to remove features and prevent maintenance and polish for the existing code. These total rewrites often take far longer than anyone anticipates. For the PW effect, it has been six years and no rewrite has even been started, and during that time, bugs and feature requests for the existing one pile up and go un-fixed because we want to rewrite it.
  
  So until the rewritten version has been released, I would like for us to continue to maintain the existing one, and evaluate patches on a case-by-case basis to see if they would introduce technical risk or exacerbate existing UI issues. I don't believe this patch does either of those things, so I request a review on its merits, rather than continuing to debate the future of the effect itself or the codebase's general fragility.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D21083

To: ngraham, #kwin, davidedmundson, broulik
Cc: abetts, apol, zzag, luebking, kossebau, graesslin, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, mart