D20890: Close screen grabbing effect when screensaver starts

zzag added inline comments.

INLINE COMMENTS

> cube.cpp:106
> +        setActive(false);
> +        if (keyboard_grab) {
> +            effects->ungrabKeyboard();

It would be very helpful to have some comment that mentions when stopMouseInterception will be called (when the stop animation has completed) and why we just ungrab keyboard here.

> flipswitch.cpp:81-84
> +        if (m_hasKeyboardGrab) {
> +            effects->ungrabKeyboard();
> +            m_hasKeyboardGrab = false;
> +        }

Don't need that.

> presentwindows.cpp:117-120
> +        if (m_hasKeyboardGrab) {
> +            effects->ungrabKeyboard();
> +            m_hasKeyboardGrab = false;
> +        }

Don't need that.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D20890

To: davidedmundson, #kwin
Cc: ngraham, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart