D21302: [tabbox] Use xkb to determine depressed modifiers on X11

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  A keysym can be assigned to several keycodes, so more proper way to
  determine whether given modifier is depressed is to iterate over all
  returned keycodes and see if any is pressed.
  
  If we check only the first keycode, then alternative mappings may not
  work, e.g. win key mapped to alt, etc.
  
  On the other hand, X11 platform already feeds xkb with key events, so we
  could use it to determine the effective state of modifiers on both X11
  and Wayland session.
  
  BUG: 407720

REPOSITORY
  R108 KWin

BRANCH
  tabbox-modifiers

REVISION DETAIL
  https://phabricator.kde.org/D21302

AFFECTED FILES
  tabbox/tabbox.cpp

To: zzag, #kwin
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.