D16648: Open externally called files/directories in new tabs
Fabian Vogt <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin,gmane.comp.kde.devel.kfm |
|---|---|
| Message-ID | <[email protected]> |
fvogt added a comment. In D16648#467893 <https://phabricator.kde.org/D16648#467893>, @feverfew wrote: > In D16648#467854 <https://phabricator.kde.org/D16648#467854>, @fvogt wrote: > > > It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs. > > > If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions. Not quite sure whether Qt supports that, but you could overload the methods of MainWindow so that the slots accept a QStringList and just pass it on. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D16648 To: feverfew, #dolphin, elvisangelaccio Cc: fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov