D16648: Open externally called files/directories in new tabs
Alexander Saoutkin <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin,gmane.comp.kde.devel.kfm |
|---|---|
| Message-ID | <[email protected]> |
feverfew added inline comments.
INLINE COMMENTS
> fvogt wrote in global.cpp:127
> `if (isUrlOpen.isValid() && isUrlOpen.value()) {`
This might be dangerous? The wording of the docs doesn't make it too clear: https://doc.qt.io/qt-5/qdbusreply.html#value
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D16648
To: feverfew, #dolphin, elvisangelaccio
Cc: dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov