D16648: Open externally called files/directories in new tabs
Alexander Saoutkin <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kfm,gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
feverfew marked an inline comment as done. feverfew added inline comments. INLINE COMMENTS > feverfew wrote in global.cpp:127 > This might be dangerous? The wording of the docs doesn't make it too clear: https://doc.qt.io/qt-5/qdbusreply.html#value Even though `isUrlOpen.value()` may give an "undefined" value, it doesn't matter as `isUrlOpen.isValid()` will be false. > elvisangelaccio wrote in global.h:50 > Prefer `QString()` to `""`. > > I wonder if we could add new flags to `OpenNewWindowFlag` and get rid of these bools in the signature. At a cursory glance, might make it more messier as we'll need `if` conditionals as we can't set flags over DBus. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D16648 To: feverfew, #dolphin, elvisangelaccio Cc: dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov