D16648: Open externally called files/directories in new tabs
Thomas Posch <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kfm,gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
thomasp reopened this revision.
thomasp added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> global.cpp:84
> + const QString pattern = QStringLiteral("org.kde.dolphin-");
> + const QString myPid = QString::number(QCoreApplication::applicationPid());
> + QVector<QPair<QSharedPointer<QDBusInterface>, QStringList>> dolphinServices;
Prepend '-' to myPid so it does not accidentally skip pid {1123, 2123, ...} when the applicationPid is 123. (service.endsWith(myPid) on line 99)
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D16648
To: feverfew, #dolphin, elvisangelaccio
Cc: thomasp, zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov