D21601: Avoid again invalid geometry of internal clients

zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> shell_client.cpp:1221-1222
>          QRect rect = QRect(surface->position(), m_clientSize + QSize(borderLeft() + borderRight(), borderTop() + borderBottom()));
> -        doSetGeometry(rect);
> +        // Shell surfaces of internal windows are sometimes desync to current value.
> +        // Make sure to not set window geometry of internal windows to invalid values (bug 386304)
> +        if (!m_internal || rect.isValid()) {

Please mention this is a workaround.

REPOSITORY
  R108 KWin

BRANCH
  avoidInvalidGeo

REVISION DETAIL
  https://phabricator.kde.org/D21601

To: romangg, #kwin, zzag
Cc: zzag, kwin, LeGast00n, ericadams, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart