D21654: Move non-Compositor functions out of composite.cpp source file

zzag added a comment.


  In general, +1, but this sort of changes raises a dilemma: do we want to keep git history or have tidy code? If do same thing for activation.cpp and geometry.cpp a lot of git history will be lost. I think we have to keep history of geometry.cpp because geometry handling in kwin is super weird.
  
  I have some coding style nitpicks.

INLINE COMMENTS

> composite.cpp:37
> +#include "workspace.h"
> +#include "unmanaged.h"
> +#include "xcbutils.h"

This include directive should be before line 33.

> composite.cpp:58
> +#include <QTimerEvent>
> +#include <QQuickWindow>
> +

QQuickWindow has to go before QTextStream.

> composite.cpp:63
>  
> +#include <stdio.h>
> +

stdio.h is deprecated in C++, include cstdio instead.

> toplevel.cpp:20
>  *********************************************************************/
> -
>  #include "toplevel.h"

Unrelated whitespace change.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D21654

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, ericadams, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart