D21654: Move non-Compositor functions out of composite.cpp source file
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added a comment. In D21654#478038 <https://phabricator.kde.org/D21654#478038>, @zzag wrote: > In general, +1, but this sort of changes raises a dilemma: do we want to keep git history or have tidy code? If do same thing for activation.cpp and geometry.cpp a lot of git history will be lost. I think we have to keep history of geometry.cpp because geometry handling in kwin is super weird. In my opinion tidy code is more important than git history in every aspect. This mantra of not changing git history too much blocks us unnecessarily of moving KWin forward. Also `geometry.cpp` needs at some point in the future some major structural changes making most of its previous git history difficult or impossible to be understood. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D21654 To: romangg, #kwin Cc: zzag, kwin, LeGast00n, ericadams, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart