D19207: [platforms/x11/windowed] Port to AbstractOutput

zzag added a comment.


  I have some nitpick, please address before landing this revision.

INLINE COMMENTS

> x11windowed_backend.h:119
> +
> +    QVector<X11WindowedOutput*> m_outputs;
>  };

Coding style nitpick: missing whitespace before `*`.

> x11windowed_output.h:46
> +    explicit X11WindowedOutput(X11WindowedBackend *backend);
> +    virtual ~X11WindowedOutput();
> +

I'm pretty sure that QObject has virtual destructor, so we can drop `virtual` part. On the other hand, we could add `override` keyword just to be sure that our base class has virtual destructor.

> x11windowed_output.h:68
> +     * @param pixelSize output size as seen from the outside
> +     */
> +    void setGeometry(const QPoint &logicalPosition, const QSize &pixelSize);

**/

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D19207

To: romangg, #kwin
Cc: davidedmundson, zzag, kwin, LeGast00n, ericadams, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart