D17900: Introduce a dynamic enabled mode in virtual keyboard

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Urgh, we need to be better at handling our review queue :/

INLINE COMMENTS

> virtualkeyboard.cpp:551
> +        return m_dynamicEnabled;
> +    default:
> +        Q_UNREACHABLE();

I prefer not putting default for a finite enum set, that way we get a warning if it goes out of sync.

REPOSITORY
  R108 KWin

BRANCH
  virtual-keyboard-dynamic

REVISION DETAIL
  https://phabricator.kde.org/D17900

To: graesslin, #kwin, davidedmundson
Cc: davidedmundson, zzag, mart, kwin, LeGast00n, ericadams, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol