D22109: [platformsupport] Minor code style and class variables access changes
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added a comment. In D22109#487099 <https://phabricator.kde.org/D22109#487099>, @zzag wrote: > > Some of these variables have been declared protected but can apparently also be private. > > That's because SceneOpenGLTexture and OpenGLWindowPixmap are fwends. It's somewhat weird to declare a friend class, which is specific to one scene, in a generic-ish class. On the other hand, we have only one OpenGL scene. While there is a friend relation they are not in a parent-child relation. From my understanding conceptually they are both on the same level inside KWin. OpenGLWindowPixmap represents a WindowPixmap in the OpenGl scene while SceneOpenGlTexture represents the actual texture in it. The platform separation is then done one level below in the OpenGlBackend child classes and their respective SceneOpenGLTexturePrivate implementations. REPOSITORY R108 KWin BRANCH styleOpenGlTexture REVISION DETAIL https://phabricator.kde.org/D22109 To: romangg, #kwin, zzag Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart